Conversation
|
| "react-test-renderer": "19.1.0", | ||
| "rimraf": "catalog:" | ||
| }, | ||
| "peerDependencies": { |
There was a problem hiding this comment.
I think these should be dependencies rather than peer dependencies as this is an endpoint package. If these are peer dependencies these packages should be added as devDependencies.
There was a problem hiding this comment.
I believe this is the output of lint-package-fix. I'll see what happened
| "@fluentui-react-native/radio-group": "workspace:*", | ||
| "@fluentui-react-native/tooltip": "workspace:*", | ||
| "@fluentui-react-native/vibrancy-view": "workspace:*", | ||
| "react-native-macos": "^0.73.0 || ^0.74.0 || ^0.78.0 || ^0.81.0", |
There was a problem hiding this comment.
For win32 I don't think macos needs to be a peer dependency.
Description of changes
We have some tasks that run per pacakge (
build,lint, etc), and some that run at the workspace level (lint-lockfile,formatbecause its way faster that way, etc. We didn't clearly delineate these two types of tasks and Lage would get confused when I tried to. So, I asked Claude to do it.Claudes summary of the changes below
Verification
CI should pass
Pull request checklist
This PR has considered (when applicable):